Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format function types - improve requireLocale error message #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix format function types - improve requireLocale error message #8

wants to merge 5 commits into from

Conversation

aminya
Copy link

@aminya aminya commented Apr 18, 2022 •
edited
Loading

  • fix: fix the return type of format
  • fix: accept number in format
  • fix: add missing docstring to the types
  • fix: fix the error caused by using bundled time-delta in node env
  • fix: add missing numerous locale registrations needed in the browser code

Fixes #7

@aminya aminya changed the title Fix format function types Fix format function types - improve requireLocale error message Apr 18, 2022
@aminya
Copy link
Author

aminya commented Oct 19, 2022

@slavafomin could you take a look at this?

@aminya
Copy link
Author

aminya commented Aug 20, 2024

@betsol Could you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Types are incorrect
1 participant
@aminya